Added label support#101
Conversation
StrawnSC
left a comment
StrawnSC
left a comment
There was a problem hiding this comment.
Can you fix the linter issues? Basically the help text needs to be added and corrected:
- We need help text for the label command group as well as the label add and remove commands
- The new commands need parameter help text
- The two command examples for the command
az containerapp ingress traffic setare invalid (they use the old parameter (--traffic-weight)
You should also merge the latest commits on the may11 branch (I fixed the style issues on that branch) and rerun the style check
Having --ids support for revision label add probably doesn't make sense btw (IIRC the fix here is to have id_part=None for the name/rg params on that command)
The containerapp --name inferring doesn't seem to work (leaving off --name says (--name | --ids) are required)
|
Also this seems like a bug:
Basically I had two revisions with a traffic split of 95/5. I renamed the 5% with the label "express". I then tried to adjust the weights to 50/50 with So it seems like adjusting weights with just a single value doesn't work when using labels? |
…' into revisionlabels
… to no name given for revision command and latest passed. Added revision name inference from --revision to revision label add.
2 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.